GSAGH-550, GSAGH-560 : Analysis case is not consistent with the Load case in Gsa_GH #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psarras
requested changes
Dec 20, 2024
…SA-Grasshopper into task/GSAGH-550-default-task
psarras
requested changes
Dec 24, 2024
| LengthUnit.Meter, Length.Zero, false, null); | ||
| var model = new GsaModel(assembly.GetModel()); | ||
| List<GsaAnalysisTaskGoo> importedTasks = model.GetAnalysisTasksAndCombinations().Item1; | ||
|
|
There was a problem hiding this comment.
use equality operator on every type so we avoid long loops of asserts
Suggested change
| Assert.Equal(importedTasks, seedTasks); |
There was a problem hiding this comment.
I used existing helper class Assert.True(Duplicates.AreEqual(seedTasks, importedTasks));
Co-authored-by: Stamatios Psarras <[email protected]>
…SA-Grasshopper into task/GSAGH-550-default-task
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #737 +/- ##
=====================================
Coverage 90.4% 90.4%
=====================================
Files 531 532 +1
Lines 39305 39303 -2
Branches 4919 4914 -5
=====================================
Hits 35538 35538
+ Misses 2501 2500 -1
+ Partials 1266 1265 -1
|
SandeepArup
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created default task in load case order and hence able to pull result