-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug Fixes #547
Bug Fixes #547
Conversation
Update: Pyupdev still complains about the latest version of flask caching so I'm reverting it back to what it was. |
Codecov Report
@@ Coverage Diff @@
## master #547 +/- ##
==========================================
- Coverage 76.71% 75.32% -1.40%
==========================================
Files 45 48 +3
Lines 2766 2946 +180
==========================================
+ Hits 2122 2219 +97
- Misses 644 727 +83
Continue to review full report at Codecov.
|
@adamsclafani many thanks! Do you have any testing recommendations for @nzola @jvonau @deldesir to try this out? |
The fix for Flask-Caching is in 1.10.2 or later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good enough for now.
@adamsclafani should this PR be merged today, to advance testing prior to the Lokole call 4PM PDT tomorrow? (Or thanks for clarifying what next step's best!) |
Please also check out the progress that occurred over the past 3 hours here:
|
Changed 'bcrypt' to 'python3-bcrypt' which was causing the install script to fail #538.
Fixed bug where the hostname was None when checking for a preexisting internet connection
Updated flask caching due PyUpdev insecure warning.