Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fixes #547

Merged
merged 4 commits into from
May 18, 2021
Merged

Bug Fixes #547

merged 4 commits into from
May 18, 2021

Conversation

adamsclafani
Copy link
Contributor

Changed 'bcrypt' to 'python3-bcrypt' which was causing the install script to fail #538.

Fixed bug where the hostname was None when checking for a preexisting internet connection

Updated flask caching due PyUpdev insecure warning.

@adamsclafani
Copy link
Contributor Author

Update:

Pyupdev still complains about the latest version of flask caching so I'm reverting it back to what it was.

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2021

Codecov Report

Merging #547 (9697f93) into master (3bf8167) will decrease coverage by 1.39%.
The diff coverage is 54.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #547      +/-   ##
==========================================
- Coverage   76.71%   75.32%   -1.40%     
==========================================
  Files          45       48       +3     
  Lines        2766     2946     +180     
==========================================
+ Hits         2122     2219      +97     
- Misses        644      727      +83     
Impacted Files Coverage Δ
opwen_email_client/webapp/tasks.py 43.58% <23.07%> (-3.08%) ⬇️
opwen_email_client/util/network.py 30.00% <30.00%> (ø)
opwen_email_client/webapp/actions.py 34.34% <30.95%> (-0.92%) ⬇️
opwen_email_client/webapp/views.py 41.25% <33.33%> (-0.34%) ⬇️
opwen_email_client/webapp/forms/register.py 45.23% <45.23%> (ø)
opwen_email_client/webapp/forms/email.py 34.94% <60.00%> (-0.38%) ⬇️
opwen_email_server/services/sendgrid.py 91.79% <63.63%> (-2.61%) ⬇️
opwen_email_server/mailers/wikipedia.py 97.77% <97.77%> (ø)
opwen_email_client/webapp/config.py 100.00% <100.00%> (ø)
opwen_email_server/mailers/__init__.py 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2785a32...9697f93. Read the comment docs.

@holta
Copy link

holta commented May 16, 2021

@adamsclafani many thanks!

Do you have any testing recommendations for @nzola @jvonau @deldesir to try this out?

@jvonau
Copy link

jvonau commented May 17, 2021

The fix for Flask-Caching is in 1.10.2 or later.
Have a look at https://pyup.io/repos/github/ascoderu/lokole/ and click on 'Requirements' for an overall perspective.

Copy link

@jvonau jvonau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good enough for now.

@holta
Copy link

holta commented May 17, 2021

@adamsclafani should this PR be merged today, to advance testing prior to the Lokole call 4PM PDT tomorrow?

(Or thanks for clarifying what next step's best!)

@holta
Copy link

holta commented May 17, 2021

@adamsclafani should this PR be merged today, to advance testing prior to the Lokole call 4PM PDT tomorrow?

(Or thanks for clarifying what next step's best!)

Please also check out the progress that occurred over the past 3 hours here:

@adamsclafani adamsclafani merged commit aa7ac11 into master May 18, 2021
@adamsclafani adamsclafani deleted the bcryptnamechange branch May 22, 2021 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants