Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest git submodule init / update in README #125

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

martinemde
Copy link

@martinemde martinemde commented Jan 4, 2025

When I went to build this (after building skia) I had these errors that blocked the build:

CMake Error at CMakeLists.txt:62 (add_subdirectory):
  The source directory

   path/to/laf/clip

  does not contain a CMakeLists.txt file.


CMake Error at third_party/CMakeLists.txt:10 (add_subdirectory):
  The source directory

   path/to/laf/third_party/googletest

  does not contain a CMakeLists.txt file.

The solution is to init and update submodules after cloning.

git submodule update --init

This will fetch the correct files and allow you to build.

It would be nice to make sure others know to init and update submodules when they fetch the code. I rarely work in projects that have submodules so I didn't immediately realize this was simple to solve.

I agree that my contributions are licensed under the MIT License.
You can find a copy of this license at https://opensource.org/licenses/MIT

@dacap dacap self-assigned this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants