Changed the '_lines' data structure from Appender to built-in array, as the former leaks memory #227
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, when translating kernel header files, memory usage for d++ reached 6-7GB on an 8GB machine (and we no longer could spawn a process for CPP to preprocess the .tmp file).
After seeing this issue, I changed from Appender to built-in array type and got a max RAM usage of 2GB (and CPP ran successfully).
Regarding performance, Edi ran some tests and saw no major difference between the Appender and the built-in array (test done on 1 million 20 char-long strings being appended, Appender being faster by 20ms).