Add support for HTTPS callbacks [SDK-4749] #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 22, 2024
| } else if let error = $1 { | ||
| return callback(.failure(WebAuthError(code: .other, cause: error))) | ||
| } | ||
|
|
There was a problem hiding this comment.
Are these bogus code coverage problems? It seems to be complaining about a blank line not being covered.
There was a problem hiding this comment.
This is due to partial coverage in this line:
Which isn't even relevant anymore, as with Xcode 15 URLComponents and URL now have the same parsing behavior: https://forums.swift.org/t/url-string-behavior-changed-with-xcode-15-0-beta-5/66570
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
This PR adds a new
useHTTPS()method toWebAuth. It allows to use HTTPS redirect URLs when performing web-based authentication on iOS 17.4+ and macOS 14.4+:🎯 Testing
These changes have been tested manually with iOS 17.4 beta 3 and iOS 17.2, using Xcode 15.3 beta 3 (15E5194e).