Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch over to npm #840

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Switch over to npm #840

merged 3 commits into from
Dec 20, 2023

Conversation

ewanharris
Copy link
Contributor

Changes

Moves over to using npm instead of yarn for the repo.

641bbcf - Handles moving all the files and references over

The scripts usage has changed slightly due to differences between npm and yarn (i.e. yarn examples android isn't achievable in npm) but I've tried to replace with dedicated scripts where possible.

9d76a74 - Handles the issue that arose due to npm enforcing peer-dependencies, this necessitated a move to newer version of react-testing-library which required the following changes

  • Remove @testing-library/react-hooks, the renderHook function is now in the main library
  • Replace usage of waitForNextUpdate with waitFor from RTL, this required changes to how we were waiting to advance, mostly it just required adding a check to make sure the library had loaded before continuing on. In 2 tests where we test for errors it was handled slightly different.

Checklist

Copy link

semgrep-app bot commented Dec 20, 2023

Semgrep found 1 ssc-020778f8-d42f-49f0-88bc-af77d7f9644b finding:

Risk: vm2 versions before and including 3.9.19 are vulnerable to Sandbox Escape. Promise handler sanitization can be bypassed, allowing attackers to escape the sandbox and run arbitrary code.

Fix: There are no safe versions of this library available for upgrade. Library included at react-native-auth0/package-lock.json:23185.

Reference(s): GHSA-cchq-frgv-rjh5, CVE-2023-37466

Ignore this finding from ssc-020778f8-d42f-49f0-88bc-af77d7f9644b.

@frederikprijck frederikprijck merged commit f854167 into master Dec 20, 2023
7 of 8 checks passed
@frederikprijck frederikprijck deleted the chore/move-to-npm branch December 20, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants