Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fast sync algorithm fixes #2779

Merged

Conversation

nazar-pc
Copy link
Member

This fixes a few issues I found in my 2 hour testing of #2763

It fixes frequent state sync download failures, improves block import performance and removes incorrect import of last block of second last segment that breaks invariants expected by archiver and violates specification.

I left a few TODOs I was lazy fixing immediately myself. But I did a few simplifications and removed some of the unnecessary changes.

Now code follows specification more closely except state import is not done atomically during import of the first block of last segment.

With these I have successfully synced Gemini 3h chain without any issues.

Code contributor checklist:

@nazar-pc nazar-pc requested a review from shamil-gadelshin May 21, 2024 22:51
@nazar-pc nazar-pc requested a review from rg3l3dr as a code owner May 21, 2024 22:51
@nazar-pc nazar-pc mentioned this pull request May 21, 2024
1 task
@shamil-gadelshin shamil-gadelshin merged commit 9685fe9 into add-fast-sync-algorithm May 22, 2024
9 checks passed
@shamil-gadelshin shamil-gadelshin deleted the add-fast-sync-algorithm-fixes branch May 22, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants