Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few issues I found in my 2 hour testing of #2763
It fixes frequent state sync download failures, improves block import performance and removes incorrect import of last block of second last segment that breaks invariants expected by archiver and violates specification.
I left a few TODOs I was lazy fixing immediately myself. But I did a few simplifications and removed some of the unnecessary changes.
Now code follows specification more closely except state import is not done atomically during import of the first block of last segment.
With these I have successfully synced Gemini 3h chain without any issues.
Code contributor checklist: