Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_cluster_merger): Created Schema file and updated ReadME file for parameters settings #9977

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vish0012
Copy link
Contributor

@vish0012 vish0012 commented Jan 20, 2025

Description

  • Implement the ROS Node configuration layout described in Autoware Foundation Discussion #3371 for the (autoware_cluster_merger)
  • Remove duplication of parameter declaration between the source code and the parameter file.
  • Remove the default value from the source code to ensure all parameter values are passed from the parameter files.
  • Use types that match those returned from declare_parameter() to prevent confusion and potential coding errors.
  • Move the default parameter file to a standardized location. Use the JSON Schema for that.
  • Create the schema

Related links

Parent Issue:

  • Link

How was this PR tested?

Package built locally.
colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to autoware_cluster_merger

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Jan 20, 2025
Copy link

github-actions bot commented Jan 20, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@vish0012 vish0012 changed the title feat: Created Schema file and updated ReadME file for parameters sett… feat(autoware_cluster_merger): Created Schema file and updated ReadME file for parameters sett… Jan 20, 2025
@vish0012 vish0012 changed the title feat(autoware_cluster_merger): Created Schema file and updated ReadME file for parameters sett… feat(autoware_cluster_merger): Created Schema file and updated ReadME file for parameters settings Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

1 participant