feat: allow remapping of can_fd topics via launch file #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzAlbers
force-pushed
the
feature/remap-can-fd-topics
branch
from
09e3b49 to
a5f862e
Compare
JWhitleyWork
approved these changes
Dec 4, 2024
|
Not sure why the CI is not initiated. |
Signed-off-by: Franz Albers <[email protected]>
xmfcx
force-pushed
the
feature/remap-can-fd-topics
branch
from
a5f862e to
80c670f
Compare
Signed-off-by: M. Fatih Cırıt <[email protected]>
xmfcx
changed the title
Right now github and its public runners are having some server issues. I will look into the failing CIs tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #39, remapping can (but not can_fd) topics via launch file arguments was enabled. This PR also allows the remapping of can_fd topics via launch file arguments while keeping the current default values for both can and can_fd topics.