Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compute_kernel #13

Merged
merged 6 commits into from
Dec 19, 2023
Merged

Add compute_kernel #13

merged 6 commits into from
Dec 19, 2023

Conversation

MartinuzziFrancesco
Copy link
Member

@MartinuzziFrancesco MartinuzziFrancesco commented Dec 17, 2023

Adding the function compute_kernel, (named computeKernel on spyndex). To do list:

  • Define the function and dispatch structure
  • Add the kernel functions
  • Dispatch on Dicts for numbers and arrays
  • Dispatch on DataFrames
  • Dispatch on YAXArrays
  • Documentation
  • Tests

Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (b206b8a) 79.58% compared to head (ec97ead) 74.46%.

Files Patch % Lines
src/compute_kernel.jl 68.88% 14 Missing ⚠️
src/compute_index.jl 84.61% 2 Missing ⚠️
src/utils.jl 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   79.58%   74.46%   -5.12%     
==========================================
  Files           5        6       +1     
  Lines         240      282      +42     
==========================================
+ Hits          191      210      +19     
- Misses         49       72      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MartinuzziFrancesco MartinuzziFrancesco merged commit 61c8635 into main Dec 19, 2023
5 of 7 checks passed
@MartinuzziFrancesco MartinuzziFrancesco deleted the fm/ck branch December 19, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant