feat(adapter-nextjs): surface redirect error and sign-in timeout error #14116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjarvisp
reviewed
Jan 7, 2025
packages/adapter-nextjs/src/auth/handlers/handleSignInCallbackRequest.ts
Outdated
Show resolved
Hide resolved
ashika112
approved these changes
Jan 7, 2025
jjarvisp
approved these changes
Jan 7, 2025
HuiSF
force-pushed
the
feat/server-auth/main
branch
from
778c2b6 to
07c5d70
Compare
HuiSF
force-pushed
the
feat/server-auth/main
branch
from
07c5d70 to
778c2b6
Compare
HuiSF
force-pushed
the
hui/feat/server-auth/error-handling
branch
from
95a6929 to
91a0248
Compare
jjarvisp
reviewed
Jan 10, 2025
packages/adapter-nextjs/src/auth/utils/createErrorSearchParamsString.ts
Outdated
Show resolved
Hide resolved
AllanZhengYP
approved these changes
Jan 10, 2025
AllanZhengYP
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
redirectOnSignOutCompleteredirectOnSignOutCompletea. adjusted the timeout from 10 mins to 5 mins to align with Amazon Cognito Hosted UI behavior (see inline documentation link)
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.