-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parameters): add feature for creating and updating Parameters and Secrets #2858
feat(parameters): add feature for creating and updating Parameters and Secrets #2858
Conversation
SonarCloud Quality Gate failed. 2 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
@heitorlessa @aradyaron @leandrodamascena |
@sthulb would you be able to do a quick pass on UX? I can look into it tomorrow afternoon (Boston time this week). Hey @stephenbawks Leandro, Ruben and I are on events this week (delays) so we appreciate the nudge |
This PR is now ready for the final reviews before merging! Huge thanks to @stephenbawks and @heitorlessa for all their hard work and contributions! Following some additional information about itens I've addressed:
We are working exclusively with AWS on this provider, if we have to extend to another provider from
Yes, it makes sense to return the dict that comes from the SDK so that the customer can choose what information he wants to use. For this, I created Please let me know if you have any questions. |
Starting reviewing now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, first pass. Will look into the documentation on the next pass.
examples/parameters/src/getting_started_set_ssm_parameter_overwrite.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left two small things, otherwise approved!
Quality Gate passedIssues Measures |
Issue number: #2826
Summary
This PR boosts parameter and secret management by allowing updates and creations. With enhanced functionality, it allow users to efficiently manage existing parameters and secrets, while also facilitating the creation of new ones as needed.
User experience
Setting parameter
Setting secret
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.