-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(data_classes): add support for Bedrock Agents event #3262
Conversation
79aef90
to
2b4cf35
Compare
any chance for parser schema too? |
Signed-off-by: Leandro Damascena <[email protected]>
Yeah @ran-isenberg! We will add support for Parser and Event Handler. |
Update: As of October 31, 2023, the payload structure of the Lambda input event and response format is changing. So I'm updating this PR to reflect the changes |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3262 +/- ##
===========================================
- Coverage 95.09% 95.06% -0.04%
===========================================
Files 202 203 +1
Lines 9408 9470 +62
Branches 1719 772 -947
===========================================
+ Hits 8947 9003 +56
- Misses 341 345 +4
- Partials 120 122 +2
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments and we are good to merge after addressing them.
aws_lambda_powertools/utilities/data_classes/bedrock_agent_event.py
Outdated
Show resolved
Hide resolved
aws_lambda_powertools/utilities/data_classes/bedrock_agent_event.py
Outdated
Show resolved
Hide resolved
aws_lambda_powertools/utilities/data_classes/bedrock_agent_event.py
Outdated
Show resolved
Hide resolved
@leandrodamascena ready for another review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APPROVED!!!
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Issue number: #3261
Summary
Changes
This PR adds event data class support for the Bedrock Agent events and response payloads.
Official docs: https://docs.aws.amazon.com/bedrock/latest/userguide/agents-create.html
User experience
Before:
After this PR, we could start writing Lambdas for Bedrock Agents like this:
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.