Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(event_handler): fix BedrockAgentResolver docstring #3645

Merged

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #3644

Summary

Changes

Fixing issue about example docstring not displaying correctly because closing ``` is missing

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner January 18, 2024 11:30
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 18, 2024
@leandrodamascena leandrodamascena linked an issue Jan 18, 2024 that may be closed by this pull request
1 task
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1409499) 95.51% compared to head (f7f2a4a) 95.56%.
Report is 4 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3645      +/-   ##
===========================================
+ Coverage    95.51%   95.56%   +0.04%     
===========================================
  Files          211      213       +2     
  Lines         9860     9961     +101     
  Branches      1802     1824      +22     
===========================================
+ Hits          9418     9519     +101     
  Misses         329      329              
  Partials       113      113              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leandrodamascena leandrodamascena merged commit 3c63c24 into aws-powertools:develop Jan 18, 2024
22 checks passed
@leandrodamascena leandrodamascena deleted the docs-bedrock-fix branch January 18, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
event_handlers size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Missing closing ``` from function comment
3 participants