Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(idempotency): add from __future__ import annotations #4961

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

ericbn
Copy link
Contributor

@ericbn ericbn commented Aug 13, 2024

Issue number: #4964

Summary

Changes

Add from __future__ import annotations to idempotency package

User experience

Discussed in #4607

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@ericbn ericbn requested a review from a team as a code owner August 13, 2024 16:59
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 13, 2024
and update code according to ruff rules TCH, UP006, UP007, UP037 and
FA100.
@ericbn ericbn force-pushed the idempotency_annotations branch from 6c0bb17 to dccc3dc Compare August 13, 2024 17:00
@boring-cyborg boring-cyborg bot added the jmespath JMESPath Functions utility label Aug 13, 2024
@ericbn ericbn force-pushed the idempotency_annotations branch from 66fd4bf to dccc3dc Compare August 13, 2024 17:08
Copy link

Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED!

@leandrodamascena leandrodamascena merged commit 421efdc into aws-powertools:v3 Aug 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement jmespath JMESPath Functions utility size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tech debt: add from __future__ import annotations in the Idempotency feature
2 participants