Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parameters): fix force_fetch feature when working with get_parameters #5515

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #5482

Summary

Changes

The force_fetch=True option in get_parameters() was not updating cached values as expected, causing Lambda functions to use outdated parameter values even after updates in SSM.

Solution:

  1. Fixed the parameter order in the get_multiple function.
  2. The parameters force_fetch and raise_on_transform_error were inverted, causing force_fetch value to be ignored.
  3. Aligned the function signature with the main class expectation of **kwargs.

User experience

No changes

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner November 6, 2024 23:01
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 6, 2024
Copy link

sonarqubecloud bot commented Nov 6, 2024

@github-actions github-actions bot added the bug Something isn't working label Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.16%. Comparing base (e266f54) to head (6e07cfd).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5515   +/-   ##
========================================
  Coverage    96.16%   96.16%           
========================================
  Files          229      229           
  Lines        10810    10810           
  Branches      2007     2007           
========================================
  Hits         10395    10395           
  Misses         327      327           
  Partials        88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leandrodamascena leandrodamascena merged commit 6cfbbc9 into develop Nov 7, 2024
15 checks passed
@leandrodamascena leandrodamascena deleted the fix/parameters branch November 7, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: parameters.get_parameters(.., max_age=24*60*60, force_fetch=True) does not work as expected anymore
2 participants