Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runtime): add Python 3.13 support #5527

Merged
merged 19 commits into from
Nov 14, 2024
Merged

feat(runtime): add Python 3.13 support #5527

merged 19 commits into from
Nov 14, 2024

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #5411

Summary

Changes

Lambda already published the base image for Python 3.13 (preview mode) and then we can start adding support for this new runtime in Powertools.

User experience

WIP

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner November 8, 2024 17:35
@boring-cyborg boring-cyborg bot added dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation github-actions Pull requests that update Github_actions code github-templates internal Maintenance changes tests labels Nov 8, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 8, 2024
@leandrodamascena leandrodamascena marked this pull request as draft November 8, 2024 17:35
@github-actions github-actions bot added feature New feature or functionality and removed documentation Improvements or additions to documentation internal Maintenance changes labels Nov 8, 2024
@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation internal Maintenance changes typing Static typing definition related issues (mypy, pyright, etc.) labels Nov 8, 2024
@github-actions github-actions bot removed documentation Improvements or additions to documentation internal Maintenance changes labels Nov 8, 2024
@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation internal Maintenance changes labels Nov 8, 2024
@github-actions github-actions bot removed documentation Improvements or additions to documentation internal Maintenance changes labels Nov 8, 2024
@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation internal Maintenance changes labels Nov 8, 2024
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Nov 8, 2024
@dreamorosi
Copy link
Contributor

CI is failing with

OSError: [Errno 28] No space left on device

😰

@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation internal Maintenance changes labels Nov 14, 2024
@leandrodamascena
Copy link
Contributor Author

@github-actions github-actions bot removed documentation Improvements or additions to documentation internal Maintenance changes labels Nov 14, 2024
@leandrodamascena
Copy link
Contributor Author

CI is failing with

OSError: [Errno 28] No space left on device

😰

To be honest, this was my fault. I was running the CDK layer tests with an matrix of all Python versions, but I don't need that because I don't want to test if it's being built on a specific Python version, we know that build, I want to know if given a Python Runtime I can build the dockefile and synthesize CloudFormation.

Lets wait the CI run again.

@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation internal Maintenance changes labels Nov 14, 2024
@github-actions github-actions bot removed documentation Improvements or additions to documentation internal Maintenance changes labels Nov 14, 2024
@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation internal Maintenance changes labels Nov 14, 2024
@github-actions github-actions bot removed documentation Improvements or additions to documentation internal Maintenance changes labels Nov 14, 2024
Copy link

sonarqubecloud bot commented Nov 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
3 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dreamorosi
Copy link
Contributor

Ok thanks- can we also address the SonarCloud findings?

@leandrodamascena
Copy link
Contributor Author

3 New issues

I'd rather not change them. These warnings are related to the Dockerfile in the sense that you're deploying a Docker image and it can create extra layers, add unnecessary Docker layer space, and so on. But that's not our case, the only reason we use a Dockerfile is to build using the actual Lambda environment (base images) and address things like libraries that need to be installed for a specific architecture or OS, and architecture. We don't use this Dockerfile to serve Docker images to customers, we just "build" and extract the resulting files from that build.

I'll mark all of them as "accepted"

Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hard work on this @leandrodamascena!

@leandrodamascena
Copy link
Contributor Author

@dreamorosi ready for review.

@leandrodamascena leandrodamascena merged commit 6d07589 into develop Nov 14, 2024
18 checks passed
@leandrodamascena leandrodamascena deleted the python3.13 branch November 14, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file event_handlers feature New feature or functionality github-actions Pull requests that update Github_actions code github-templates size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tests typing Static typing definition related issues (mypy, pyright, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Bump the CDK version to add Python 3.13 support Maintenance: Support for Python 3.13
2 participants