-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(event_handler): Add new EventHandler for Async Lambda #5799
base: develop
Are you sure you want to change the base?
feat(event_handler): Add new EventHandler for Async Lambda #5799
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
Hi @sinofseven! Thank you so much for opening this PR. Do you need any help here? |
Quality Gate passedIssues Measures |
Hi, @anafalcao! Thanks very much for your suggestion! I have a few problems at the moment.
What must be done in tests other than unit testsFor the EventHandler implementation I am creating, I believe that the event samples provided for unit testing of data_classes are sufficient for testing. However, the EventHandler test for API Gateway implements E2E testing. Regarding the test case for the unit testThe unit test attempted to check all cases, including correct and incorrect values for all arguments of each Route class, as well as the presence or absence of arguments. Therefore, in creating the test, I wrote all the patterns of the test case in a Google Spreadsheet. https://docs.google.com/spreadsheets/d/1eioW7rALlFdkv2Q0y8ERZnMnJuJK3QWoPfhoJMTlqaA/edit?usp=sharing Following this, I implemented a unit test in Here is where I ran into a problem: I had a very large number of test cases in having many arguments Route class. Therefore, I am wondering how far to describe the test cases. |
Issue number: #5627
Summary
Add
AsyncTriggerResolver
.Changes
Added EventHandler for asynchronous Lambda execution.
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.