Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodetect enabled regions #5

Closed
wants to merge 3 commits into from

Conversation

devt
Copy link

@devt devt commented Feb 2, 2023

Issue #4

Autodetect regions:
If user does not provide a list of regions (or selects 'ALL') we make a call to ec2.describe_regions() (new function get_regions_for_account) for each account to determine the list of all regions which are enabled for the particular account

Please, note I have not tested this code

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@groverlalit groverlalit self-assigned this Jun 21, 2023
@groverlalit
Copy link
Member

Thanks for opening this PR. We will review this in the next release cycle.

@groverlalit groverlalit added the enhancement New feature or request label Jun 21, 2023
@groverlalit
Copy link
Member

We have reviewed this PR. We will be supporting this feature request. However, we will implement list_regions API call using 'account' client instead of describe_regions using 'ec2' client.

The prefer to use list_regions API because it allows us to provide RegionOptStatusContains=['ENABLED'|'ENABLED_BY_DEFAULT']

@groverlalit
Copy link
Member

Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants