Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to media no video codecs in Cocoapod #626

Merged
merged 4 commits into from
Dec 13, 2023

Conversation

bjason
Copy link
Contributor

@bjason bjason commented Dec 13, 2023

ℹ️ Description

Add support to media no video codecs artifact in Cocoapod. Update documentation for how to include the artifact into projects.

Issue #, if available

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • README update
    • CHANGELOG update
    • guides update
  • This change requires a dependency update
    • Amazon Chime SDK Media
    • Other (update corresponding legal documents)

🧪 How Has This Been Tested?

QA tested

Additional Manual Test

  • Pause and resume remote video
  • Switch local camera
  • Rotate screen back and forth

📱 Screenshots, if available

provide screenshots/video record if there's a UI change in demo app

✅ Checklist

Integration validation (required before release)

  • Unit tests pass
  • Build SDK against simulator with release options
  • Build SDK against device with release options
  • Build SDK against simulator with debug options
  • Build SDK against device with debug options
  • Test Demo against simulator with SDK (debug build) in workspace
  • Test Demo against device with SDK (debug build) in workspace
  • Test DemoObjC against simulator with SDK (debug build) in workspace
  • Test DemoObjC against device with SDK (debug build) in workspace
  • Test Demo against simulator with SDK.framework (release build)
  • Test Demo against device with SDK.framework (release build)
  • Test DemoObjC against simulator with SDK.framework (release build)
  • Test DemoObjC against device with SDK.framework (release build)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bjason bjason changed the base branch from master to development December 13, 2023 01:46
georgezy-amzn
georgezy-amzn previously approved these changes Dec 13, 2023
@bjason bjason requested a review from georgezy-amzn December 13, 2023 02:06
@georgezy-amzn georgezy-amzn merged commit 63cc618 into development Dec 13, 2023
2 checks passed
@georgezy-amzn georgezy-amzn deleted the video_codecs branch December 13, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants