fix: should wait for ringbuffer thread to finish before closing statement #131
+9
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If we do not wait for it, a subsequent call may have issues of
ERROR: current transaction is aborted, commands ignored until end of transaction block
.This check existed until 2.1.0.21, was replaced by method
resumeReadAndDiscardResults()
in 2.1.0.22 (this method already presented issues), and some versions later the replacement was removed in filipelautert@befa7de - so no checks for ringbuffer are done anymore when closing the connection.Motivation and Context
Liquibase Redshift extension only works with driver versions until 2.1.0.21 . After that version it fails with the presented error message.
As a workaround, we can use
?enablefetchringbuffer=false
Testing
Run any Liquibase version (most recent is 4.30.0) using redshift integration ( https://github.com/liquibase/liquibase-redshift ):
Types of changes
Checklist
mvn install
succeedsLicense