feat(dynamodb): add pointintimerecoveryspecification and deprecate old #33059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
effort/small
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33059 +/- ##
==========================================
+ Coverage 81.52% 81.57% +0.04%
==========================================
Files 224 227 +3
Lines 13762 13793 +31
Branches 2414 2419 +5
==========================================
+ Hits 11220 11251 +31
Misses 2270 2270
Partials 272 272
Flags with carried forward coverage won't be shown. Click here to find out more.
|
aws-cdk-automation
added
the
pr/needs-community-review
lpizzinidev
suggested changes
Jan 23, 2025
aws-cdk-automation
removed
the
pr/needs-community-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
GavinZZ
requested changes
Jan 24, 2025
Comment on lines
+715
to
+720
| const pointInTimeRecoverySpecification: PointInTimeRecoverySpecification | undefined = | ||
| props.pointInTimeRecoverySpecification ?? | ||
| this.tableOptions.pointInTimeRecoverySpecification ?? | ||
| (pointInTimeRecovery !== undefined | ||
| ? { pointInTimeRecoveryEnabled: pointInTimeRecovery } | ||
| : undefined); |
There was a problem hiding this comment.
A comment above this logic will be appreciated.
| * If no value is provided, the value will default to 35. | ||
| * @default 35 | ||
| */ | ||
| readonly recoveryPeriodInDays?: number; |
There was a problem hiding this comment.
Suggested change
| readonly recoveryPeriodInDays?: number; | |
| readonly recoveryPeriodInDays?: Duration; |
| const recoveryPeriodInDays = props.pointInTimeRecoverySpecification?.recoveryPeriodInDays; | ||
|
|
||
| if (props.pointInTimeRecovery !== undefined && props.pointInTimeRecoverySpecification !== undefined) { | ||
| throw new Error('`pointInTimeRecoverySpecification` and `pointInTimeRecovery` are set. Use `pointInTimeRecoverySpecification` only.'); |
There was a problem hiding this comment.
We're replacing any validation error from new Error to new ValidationError. Can you stick to the new validation error please?
| private validatePitr (props: TableProps): PointInTimeRecoverySpecification | undefined { | ||
|
|
||
| if (props.pointInTimeRecoverySpecification !==undefined && props.pointInTimeRecovery !== undefined) { | ||
| throw new Error('`pointInTimeRecoverySpecification` and `pointInTimeRecovery` are set. Use `pointInTimeRecoverySpecification` only.'); |
There was a problem hiding this comment.
same here, please use ValidationError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #32786
Reason for this change
New feature of DynamoDB
Description of changes
Added
pointInTimeRecoverySpecificationwhich takespointInTimeRecoveryEnabledandrecoveryPeriodInDays.Deprecated
pointInTimeRecoveryas it could not takerecoveryPeriodInDaysDescribe any new or updated permissions being added
Description of how you validated changes
Integ and Unit tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license