chore(examples): Add examples for Go with CI #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishav-karanjit
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
rishav-karanjit
changed the title
rishav-karanjit
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
rishav-karanjit
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
rishav-karanjit
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
rishav-karanjit
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
rishav-karanjit
changed the title
rishav-karanjit
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
rishav-karanjit
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
| @@ -0,0 +1,90 @@ | |||
| # AWS Encryption SDK for Go Examples | |||
There was a problem hiding this comment.
Rename this file to README.md
|
|
||
| The AWS Encryption SDK provides two high-level APIs: | ||
| one-step APIs that process the entire operation in memory | ||
| and streaming APIs. |
There was a problem hiding this comment.
I can't find the streaming API examples -- if it's just 1 or 2 examples could you link them specifically?
(I'm also surprised to hear this -- I was also under the impression that our Dafny libraries wouldn't support streaming until Dafny did some work. Did that get done?)
There was a problem hiding this comment.
No. This came in when I copied the readme from other runtimes. I think we don't support streaming rn.
| * How to restrict algorithm suites | ||
| * [with a custom cryptographic materials manager](./cryptographicmaterialsmanager/restrictalgorithmsuite/signingsuiteonlycmm.go) | ||
|
|
||
| ### Keyrings |
There was a problem hiding this comment.
| They determine how the AWS Encryption SDK protects your data. | ||
| You can find these examples in [`examples/keyring`](./keyring). | ||
|
|
||
| ### Cryptographic Materials Managers |
There was a problem hiding this comment.
lucasmcdonald3
previously approved these changes
Jan 8, 2025
rishav-karanjit
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
AwsEncryptionSDK/Makefile
Outdated
Comment on lines
111
to
112
| _polymorph_dependencies: | ||
| @echo "No polymorphing of dependency" |
There was a problem hiding this comment.
Should this be left in?
There was a problem hiding this comment.
Ohh no. I forgot to remove it. Thats my faster polymorph'ing trick
rishav-karanjit
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
lucasmcdonald3
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Moving all examples from here which is already PR reviewed to this repo but did following changes while moving:
commitmentpolicy.go,limitencrypteddatakeysexample.goandsetencryptionalgorithmsuite.gofiles to the misc directory to improve code organization, as these auxiliary examples are better separated from the core project files (main.go,go.modandgo.sum).AwsEncryptionSDK/runtimes/go/examples/readme.md)Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.