Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TestVectors): Add Rust support #693

Merged
merged 125 commits into from
Nov 14, 2024

Conversation

RitvikKapila
Copy link
Contributor

Issue #, if available:

Description of changes:
Add test vectors support for Rust

Squash/merge commit message, if applicable:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@RitvikKapila RitvikKapila changed the base branch from mainline to rkapila/rust-reviewed November 12, 2024 11:00
@RitvikKapila RitvikKapila marked this pull request as ready for review November 14, 2024 18:41
@RitvikKapila RitvikKapila requested a review from a team as a code owner November 14, 2024 18:41
Copy link
Contributor

@ajewellamz ajewellamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RitvikKapila RitvikKapila merged commit a4935a6 into rkapila/rust-reviewed Nov 14, 2024
46 checks passed
@RitvikKapila RitvikKapila deleted the feature/rust-support branch November 14, 2024 20:33
@josecorella
Copy link
Contributor

@RitvikKapila, I am having a hard time finding where in code we are filtering out the aes-192 tests

@ajewellamz
Copy link
Contributor

@RitvikKapila, I am having a hard time finding where in code we are filtering out the aes-192 tests

That was already done in the MPL. We're not filtering them out, we're not generating them in the first place.

@josecorella
Copy link
Contributor

we're not generating them in the first place.

Are we not generating them for just rust or for all languages we just don't generate aes-192?

@ajewellamz
Copy link
Contributor

we're not generating them in the first place.

Are we not generating them for just rust or for all languages we just don't generate aes-192?

All languages, because we need to test interoperability between languages.

Anton authorized this. We'll put the aes192 test vectors back in in a few months, when aws-lc supports it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants