-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TestVectors): Add Rust support #693
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@RitvikKapila, I am having a hard time finding where in code we are filtering out the aes-192 tests |
That was already done in the MPL. We're not filtering them out, we're not generating them in the first place. |
Are we not generating them for just rust or for all languages we just don't generate aes-192? |
All languages, because we need to test interoperability between languages. Anton authorized this. We'll put the aes192 test vectors back in in a few months, when aws-lc supports it. |
Issue #, if available:
Description of changes:
Add test vectors support for Rust
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.