chore(Test Vector): Add interop test for Go #706
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0b49193.
rishav-karanjit
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
rishav-karanjit
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
rishav-karanjit
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
rishav-karanjit
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
rishav-karanjit
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
rishav-karanjit
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
rishav-karanjit
changed the title
Comment on lines
+171
to
+173
| find .. -name "shim.go" | xargs sed -i "" 's/(_static \*CompanionStruct_Default___)//g' | ||
| find .. -name "api_client.go" -exec sed -i '' 's|"github.com/aws/aws-encryption-sdk/ESDK"|ESDK "github.com/aws/aws-encryption-sdk/EncryptionSdk"|g' {} \; | ||
| find .. -name "api_client.go" -exec sed -i '' 's|"github.com/aws/aws-encryption-sdk/testvectors/ESDK"|ESDK "github.com/aws/aws-encryption-sdk/testvectors"|g' {} \; |
There was a problem hiding this comment.
Make sure these work on all the platforms.
| @@ -37,7 +37,7 @@ module {:options "-functionSyntax:4"} WriteEsdkJsonManifests { | |||
| function EncryptionContextToJson(key: string, m: mplTypes.EncryptionContext) | |||
| : Result<seq<(string, JSON)>, string> | |||
| { | |||
| var keys := SortedSets.ComputeSetToSequence(m.Keys); | |||
| var keys := SortedSets.ComputeSetToOrderedSequence2(m.Keys, (a, b) => a < b); | |||
There was a problem hiding this comment.
Why this change?
There was a problem hiding this comment.
Recently ComputeSetToSequence is made method in MPL because the results are not deterministic and in Dafny we cannot call a method from a function. Our MPL submodule contains this change.
There was a problem hiding this comment.
Also, on recent commit to merge Rust work to main, this function was updated in mainline: https://github.com/aws/aws-encryption-sdk-dafny/blob/mainline/TestVectors/dafny/TestVectors/src/WriteEsdkJsonManifests.dfy#L40
|
Closing this as I merged this to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
How to test this?
There are two ways to test it. Use either (i) or (ii).
make test_gotest_generate_vectors_gotest_encrypt_vectors_gotest_decrypt_encrypt_vectors_goSquash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.