fix: repo rename #740
fix: repo rename #740
Conversation
ShubhamChaturvedi7
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
ShubhamChaturvedi7
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
| github.com/aws/aws-cryptographic-material-providers-library/releases/go/kms v0.0.0 | ||
| github.com/aws/aws-cryptographic-material-providers-library/releases/go/mpl v0.0.0 | ||
| github.com/aws/aws-cryptographic-material-providers-library/releases/go/primitives v0.0.0 | ||
| github.com/aws/aws-cryptographic-material-providers-library/releases/go/dynamodb v0.0.3 |
There was a problem hiding this comment.
Isn't our process replacing this package with the local version in runtime/go. But put the actual version with no replacement in releases/go directory?
There was a problem hiding this comment.
We do have a replace in place.
There was a problem hiding this comment.
Also made changes to do a version agnostic replace.
There was a problem hiding this comment.
Non blocking but I would rather put v0.0.0 (a version thats not released) in require to signal replace directives is used in the go mod.
There was a problem hiding this comment.
Not really - I'd rather have the version number and do a replace. The issue with v0.0.0 is if you really want to test against a version you have to explicitly specify it and then go mod and stuff. With the right version in place, you can just comment out the replace directive and it will work.
ShubhamChaturvedi7
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
| github.com/aws/aws-cryptographic-material-providers-library/releases/go/kms v0.0.0 | ||
| github.com/aws/aws-cryptographic-material-providers-library/releases/go/mpl v0.0.0 | ||
| github.com/aws/aws-cryptographic-material-providers-library/releases/go/primitives v0.0.0 | ||
| github.com/aws/aws-cryptographic-material-providers-library/releases/go/dynamodb v0.0.3 |
There was a problem hiding this comment.
Non blocking but I would rather put v0.0.0 (a version thats not released) in require to signal replace directives is used in the go mod.
|
Non blocking: this might be more of a refactor commit then a fix commit. |
Not really - I'd rather have the version number and do a replace. The issue with v0.0.0 is if you really want to test against a version you have to explicitly specify it and then go mod and stuff. With the right version in place, you can just comment out the replace directive and it will work. |
Issue #, if available:
Description of changes:
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.