Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow including binary files when auto build is enabled #5299

Open
wants to merge 1 commit into
base: feature/dev-execution
Choose a base branch
from

Conversation

osdemah
Copy link
Member

@osdemah osdemah commented Jan 25, 2025

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

  • Arbitrary ignoring of asset files causes build failures since they might be used in test or even directly imported in code (e.g. png/ico files in TS/JS). We should only drop files matching with gitignore rules and some other generally known folders (e.g. node_modules, .git) if auto build is enabled.
  • Jar files are not really code files and should not be included for agents that are solely textual.
  • Refactor the file ignore heuristic logic to improve readability.
  • Add the 1MB size limit per file to match the logic with vscode plugin

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@osdemah osdemah requested review from a team as code owners January 25, 2025 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant