Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom Gremlin serializers for Neptune #547

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

michaelnchin
Copy link
Member

Issue #, if available: N/A

Description of changes:

  • Removed the restriction on setting custom values for the Gremlin message_serializer field in %%graph_notebook_config when a Neptune endpoint is specified.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@krlawrence krlawrence self-requested a review December 11, 2023 19:36
Copy link
Contributor

@krlawrence krlawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for this change. It will be useful to specify different serializers, especially GraphBinary.

@michaelnchin michaelnchin merged commit 4d3248a into main Dec 11, 2023
4 checks passed
@michaelnchin michaelnchin deleted the neptune-gremlin-serializer branch December 11, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Resolved
Development

Successfully merging this pull request may close these issues.

2 participants