Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cross process Lock. #1072

Merged
merged 14 commits into from
Nov 6, 2023
Merged

Added cross process Lock. #1072

merged 14 commits into from
Nov 6, 2023

Conversation

JonathanHenson
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@JonathanHenson JonathanHenson requested a review from a team November 2, 2023 19:31
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c80ce50) 83.26% compared to head (e435dc3) 83.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1072      +/-   ##
==========================================
+ Coverage   83.26%   83.40%   +0.13%     
==========================================
  Files          55       56       +1     
  Lines        5750     5792      +42     
==========================================
+ Hits         4788     4831      +43     
+ Misses        962      961       -1     
Files Coverage Δ
source/posix/cross_process_lock.c 92.68% <92.68%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

include/aws/common/ipc_util.h Outdated Show resolved Hide resolved
source/posix/ipc_util.c Outdated Show resolved Hide resolved
source/posix/ipc_util.c Outdated Show resolved Hide resolved
source/windows/ipc_util.c Outdated Show resolved Hide resolved
source/windows/ipc_util.c Outdated Show resolved Hide resolved
source/windows/ipc_util.c Outdated Show resolved Hide resolved
source/posix/ipc_util.c Outdated Show resolved Hide resolved
source/posix/ipc_util.c Outdated Show resolved Hide resolved
source/windows/ipc_util.c Outdated Show resolved Hide resolved
source/windows/ipc_util.c Outdated Show resolved Hide resolved
Copy link
Contributor

@graebm graebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix & ship

source/windows/cross_process_lock.c Outdated Show resolved Hide resolved
include/aws/common/cross_process_lock.h Outdated Show resolved Hide resolved
JonathanHenson and others added 2 commits November 6, 2023 11:48
use proper scoping identifier for windows mutex

Co-authored-by: Michael Graeb <[email protected]>
update documentation.

Co-authored-by: Michael Graeb <[email protected]>
@JonathanHenson JonathanHenson merged commit 4a76aa0 into main Nov 6, 2023
52 checks passed
@JonathanHenson JonathanHenson deleted the cross_process_instance_check branch November 6, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants