Skip to content

Commit

Permalink
Skip cert-key tests on GraalMacos
Browse files Browse the repository at this point in the history
  • Loading branch information
@bretambrose
bretambrose committed Nov 14, 2024
1 parent f274750 commit c615947
Showing 1 changed file with 20 additions and 24 deletions.
44 changes: 20 additions & 24 deletions src/test/java/software/amazon/awssdk/crt/test/MqttRequestResponseClientTests.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import org.junit.Assume;
import org.junit.Test;
import software.amazon.awssdk.crt.CRT;
import software.amazon.awssdk.crt.CrtRuntimeException;
import software.amazon.awssdk.crt.io.TlsContext;
import software.amazon.awssdk.crt.io.TlsContextOptions;
Expand All @@ -24,10 +25,29 @@

public class MqttRequestResponseClientTests extends CrtTestFixture {

static final boolean AWS_GRAALVM_CI = System.getProperty("AWS_GRAALVM_CI") != null;

static final String AWS_TEST_MQTT5_IOT_CORE_HOST = System.getProperty("AWS_TEST_MQTT5_IOT_CORE_HOST");
static final String AWS_TEST_MQTT5_IOT_CORE_RSA_CERT = System.getProperty("AWS_TEST_MQTT5_IOT_CORE_RSA_CERT");
static final String AWS_TEST_MQTT5_IOT_CORE_RSA_KEY = System.getProperty("AWS_TEST_MQTT5_IOT_CORE_RSA_KEY");

public MqttRequestResponseClientTests() {
/**
* Disable test for native image, because:
* - On MacOS, when cert and private key used for TLS, it will be imported to KeyChain,
* and KeyChain will restrict other application to use the private key
* - For GraalVM test, Java will run the tests firstly, and import the mTLS private key.
* After that, when native test runs, it's a different application than Java,
* which will use the same key, and MacOS blocks the usage and result in hanging.
* - Locally, you can either put in your password to allow the usage, or delete the key from the KeyChain,
* But, in CI, it's very complicated, and decided to not support MQTT tests for now.
*/
Assume.assumeFalse(AWS_GRAALVM_CI && CRT.getOSIdentifier() == "osx");
Assume.assumeNotNull(
AWS_TEST_MQTT5_IOT_CORE_HOST, AWS_TEST_MQTT5_IOT_CORE_RSA_CERT,
AWS_TEST_MQTT5_IOT_CORE_RSA_KEY);
}

static private Mqtt5Client createMqtt5Client() {
try (TlsContextOptions contextOptions = TlsContextOptions.createWithMtlsFromPath(
AWS_TEST_MQTT5_IOT_CORE_RSA_CERT,
Expand Down Expand Up @@ -112,9 +132,6 @@ static private MqttClientConnection createMqtt311Client() {
@Test
public void CreateDestroyMqtt5() {
skipIfNetworkUnavailable();
Assume.assumeNotNull(
AWS_TEST_MQTT5_IOT_CORE_HOST, AWS_TEST_MQTT5_IOT_CORE_RSA_CERT,
AWS_TEST_MQTT5_IOT_CORE_RSA_KEY);

try (Mqtt5Client protocolClient = createMqtt5Client()) {
MqttRequestResponseClientBuilder rrBuilder = new MqttRequestResponseClientBuilder();
Expand All @@ -131,9 +148,6 @@ public void CreateDestroyMqtt5() {
@Test(expected = CrtRuntimeException.class)
public void Mqtt5CreateFailureBadMaxRequestResponseSubscriptions() {
skipIfNetworkUnavailable();
Assume.assumeNotNull(
AWS_TEST_MQTT5_IOT_CORE_HOST, AWS_TEST_MQTT5_IOT_CORE_RSA_CERT,
AWS_TEST_MQTT5_IOT_CORE_RSA_KEY);

try (Mqtt5Client protocolClient = createMqtt5Client()) {
MqttRequestResponseClientBuilder rrBuilder = new MqttRequestResponseClientBuilder();
Expand All @@ -148,9 +162,6 @@ public void Mqtt5CreateFailureBadMaxRequestResponseSubscriptions() {
@Test(expected = CrtRuntimeException.class)
public void Mqtt5CreateFailureBadMaxStreamingSubscriptions() {
skipIfNetworkUnavailable();
Assume.assumeNotNull(
AWS_TEST_MQTT5_IOT_CORE_HOST, AWS_TEST_MQTT5_IOT_CORE_RSA_CERT,
AWS_TEST_MQTT5_IOT_CORE_RSA_KEY);

try (Mqtt5Client protocolClient = createMqtt5Client()) {
MqttRequestResponseClientBuilder rrBuilder = new MqttRequestResponseClientBuilder();
Expand All @@ -165,9 +176,6 @@ public void Mqtt5CreateFailureBadMaxStreamingSubscriptions() {
@Test(expected = CrtRuntimeException.class)
public void Mqtt5CreateFailureBadOperationTimeout() {
skipIfNetworkUnavailable();
Assume.assumeNotNull(
AWS_TEST_MQTT5_IOT_CORE_HOST, AWS_TEST_MQTT5_IOT_CORE_RSA_CERT,
AWS_TEST_MQTT5_IOT_CORE_RSA_KEY);

try (Mqtt5Client protocolClient = createMqtt5Client()) {
MqttRequestResponseClientBuilder rrBuilder = new MqttRequestResponseClientBuilder();
Expand All @@ -182,9 +190,6 @@ public void Mqtt5CreateFailureBadOperationTimeout() {
@Test
public void CreateDestroyMqtt311() {
skipIfNetworkUnavailable();
Assume.assumeNotNull(
AWS_TEST_MQTT5_IOT_CORE_HOST, AWS_TEST_MQTT5_IOT_CORE_RSA_CERT,
AWS_TEST_MQTT5_IOT_CORE_RSA_KEY);

try (MqttClientConnection protocolClient = createMqtt311Client()) {
MqttRequestResponseClientBuilder rrBuilder = new MqttRequestResponseClientBuilder();
Expand All @@ -202,9 +207,6 @@ public void CreateDestroyMqtt311() {
@Test(expected = CrtRuntimeException.class)
public void Mqtt311CreateFailureBadMaxRequestResponseSubscriptions() {
skipIfNetworkUnavailable();
Assume.assumeNotNull(
AWS_TEST_MQTT5_IOT_CORE_HOST, AWS_TEST_MQTT5_IOT_CORE_RSA_CERT,
AWS_TEST_MQTT5_IOT_CORE_RSA_KEY);

try (MqttClientConnection protocolClient = createMqtt311Client()) {
MqttRequestResponseClientBuilder rrBuilder = new MqttRequestResponseClientBuilder();
Expand All @@ -219,9 +221,6 @@ public void Mqtt311CreateFailureBadMaxRequestResponseSubscriptions() {
@Test(expected = CrtRuntimeException.class)
public void Mqtt311CreateFailureBadMaxStreamingSubscriptions() {
skipIfNetworkUnavailable();
Assume.assumeNotNull(
AWS_TEST_MQTT5_IOT_CORE_HOST, AWS_TEST_MQTT5_IOT_CORE_RSA_CERT,
AWS_TEST_MQTT5_IOT_CORE_RSA_KEY);

try (MqttClientConnection protocolClient = createMqtt311Client()) {
MqttRequestResponseClientBuilder rrBuilder = new MqttRequestResponseClientBuilder();
Expand All @@ -236,9 +235,6 @@ public void Mqtt311CreateFailureBadMaxStreamingSubscriptions() {
@Test(expected = CrtRuntimeException.class)
public void Mqtt311CreateFailureBadOperationTimeout() {
skipIfNetworkUnavailable();
Assume.assumeNotNull(
AWS_TEST_MQTT5_IOT_CORE_HOST, AWS_TEST_MQTT5_IOT_CORE_RSA_CERT,
AWS_TEST_MQTT5_IOT_CORE_RSA_KEY);

try (MqttClientConnection protocolClient = createMqtt311Client()) {
MqttRequestResponseClientBuilder rrBuilder = new MqttRequestResponseClientBuilder();
Expand Down

0 comments on commit c615947

Please sign in to comment.