Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix connectionAcquisitionTimeoutInMilliseconds from Int to Long #858

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Fix connectionAcquisitionTimeoutInMilliseconds from Int to Long #858

merged 2 commits into from
Jan 9, 2025

Conversation

waahm7
Copy link
Contributor

@waahm7 waahm7 commented Jan 7, 2025

Description of changes:

  • The actual variable type is long but I missed updating it in the function signature.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

TingDaoK
TingDaoK approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@TingDaoK TingDaoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is another one has the same issue down at line 328
withMaxPendingConnectionAcquisitions

Fix & ship

@waahm7 waahm7 enabled auto-merge (squash) January 9, 2025 17:01
@waahm7 waahm7 merged commit 0540e17 into main Jan 9, 2025
53 checks passed
@waahm7 waahm7 deleted the fix-http-timeout-type branch January 9, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TingDaoK TingDaoK TingDaoK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waahm7 @TingDaoK