Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rsa bindings #511
rsa bindings #511
Changes from 1 commit
05fed5c
100c9a5
ff1dafb
01b149d
0f6b144
d7db28d
ad92cf9
0c46bd2
1804d55
094851a
d04c6d7
9867835
0195871
9e5966f
f9e30f8
19652f7
6ef2fc7
9011142
1968c72
379428d
90b92c6
8ecd207
c9df141
9c96fb5
e8cbbe5
acb7854
f8d269f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible that adding actual docstrings makes it public. run scripts/make-docs.py to see what the docs look like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
debatable: while it seems OK to accepting
str
when reading pem data, I'm not sure we want to acceptstr
for encrypt/decrypt/sign/verify. It does introduce some ambiguity if, for whatever reason, the user had some other string encoding going onwe would enforce this is C by taking
y#
instead ofs#
https://docs.python.org/3/c-api/arg.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
str probably makes sense for plaintext. but for ciphertext i agree removing str makes more sense. updating it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
roundtrip questions... maybe not string... we talked
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trivial: It's not 100% consistent in this codebase, but I like to do this shortcut
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PyCapsule_GetPointer() already sets a good python exception if it fails. Calling PyErr_AwsLastError() will overwrite it with nonsense from whatever stale value aws_last_error() returns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, was copying the behavior from sha impl earlier in the file. will fix