Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky tests pass 1 #616

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Flaky tests pass 1 #616

merged 3 commits into from
Jan 6, 2025

Conversation

bretambrose
Copy link
Contributor

@bretambrose bretambrose commented Dec 19, 2024

  • Update shared subscription test to remove invalid assertions on a property that does not necessarily hold (all subscriptions receive messages)
  • Make MQTT will tests more reliable by adding a delay between subscribe and disconnect, and looping the connection attempt in the 311 test which does not have the ability to send a DISCONNECT_WITH_WILL message.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bretambrose bretambrose merged commit 87746bb into main Jan 6, 2025
64 checks passed
@bretambrose bretambrose deleted the FlakyTestPass1 branch January 6, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants