Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Added ability to read in an MFA token. #18

Closed
wants to merge 5 commits into from
Closed

Added ability to read in an MFA token. #18

wants to merge 5 commits into from

Conversation

andylockran
Copy link

*Issue #13 *

Description of changes:

I've parsed the first authentication response, and upon finding MFA_REQUIRED, sends another request with the passcode and sessionToken to return a one-time-code; this then continues the normal flow of the application.

Limitations - this will always select the first MFA token . (as this resolves my use case). Will add additional functionality for multiple MFA selection and create a new issue to do so.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@joshk0
Copy link

joshk0 commented Feb 7, 2018

hi @andylockran , what is the difference between this and #14 ?

@andylockran
Copy link
Author

andylockran commented Feb 7, 2018 via email

@joshk0
Copy link

joshk0 commented Feb 8, 2018

No problem. I'm just a potential user of either of these pull requests and want to know which one I should use. It sounds like you should peek over and see if the two are mutually compatible in approach, work with the author and create a unified PR. I am wondering if the folks at AWS Labs will express a strong direction for whether this sort of thing belongs in awsprocesscreds and support the change, I think this change going in would be enormously consequential for a lot of teams using Okta and looking to tie it to AWS.

@JordonPhillips
Copy link
Contributor

Thanks for the pr! I think I would prefer to go down the route of #14, which adds support for some other things in addition to this. Does that PR address your use case?

I'm going to close this pr, but feel free to re-open if the other pr doesn't address your case.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants