Bipolar feedback had broken fb-drag-to-on (#129)

so fix that by adding an onPullFromDef
baconpaul · Jan 16, 2025 · b1f522c · b1f522c
1 parent ffc09bb
commit b1f522c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/ui/matrix-panel.cpp b/src/ui/matrix-panel.cpp
@@ -41,7 +41,7 @@ MatrixPanel::MatrixPanel(SixSinesEditor &e) : jcmp::NamedPanel("Matrix"), HasEdi
         Slabels[i]->setText("Op " + std::to_string(i + 1) + " " + u8"\U000021A9");
         addAndMakeVisible(*Slabels[i]);
 
-        SknobsData[i]->under->onPullFromMin = [i, w = juce::Component::SafePointer(this)]()
+        SknobsData[i]->under->onPullFromDef = [i, w = juce::Component::SafePointer(this)]()
         {
             if (!w)
                 return;

diff --git a/src/ui/patch-data-bindings.h b/src/ui/patch-data-bindings.h
@@ -88,6 +88,12 @@ struct PatchContinuous : jdat::Continuous
             if (onPullFromMin)
                 onPullFromMin();
         }
+
+        if (p->value == p->meta.defaultVal && f != p->value)
+        {
+            if (onPullFromDef)
+                onPullFromDef();
+        }
         p->value = f;
         editor.uiToAudio.push({Synth::UIToAudioMsg::Action::SET_PARAM, pid, f});
         editor.flushOperator();
@@ -105,7 +111,7 @@ struct PatchContinuous : jdat::Continuous
     jdat::Discrete *tsPowerPartner{nullptr};
     void setTemposyncPowerPartner(jdat::Discrete *d) { tsPowerPartner = d; }
 
-    std::function<void()> onPullFromMin{nullptr};
+    std::function<void()> onPullFromMin{nullptr}, onPullFromDef{nullptr};
 
     using cubic_t = sst::jucegui::component_adapters::CubicThrowRescaler<PatchContinuous>;
 };