Env-LFO scaling works on finetine and pan nodes

MOdulationOnlyNode had ignored lfoIsEnveloped basically Closes #75
baconpaul · Jan 3, 2025 · b2e50cb · b2e50cb
1 parent 5ef3f0b
commit b2e50cb
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/dsp/matrix_node.h b/src/dsp/matrix_node.h
@@ -530,8 +530,15 @@ struct ModulationOnlyNode : EnvelopeSupport<Patch::ModulationOnlyNode>,
         envProcess(true, false);
         lfoProcess();
 
+        auto lfoLev = lfo.outputBlock[blockSize - 1];
+
+        if (lfoIsEnveloped)
+        {
+            lfoLev = lfoLev * env.outBlock0;
+        }
+
         level = directMod + env.outBlock0 * (envD + edMod) * envAtten +
-                lfo.outputBlock[blockSize - 1] * (lfoD + ldMod) * lfoAtten;
+                lfoLev * (lfoD + ldMod) * lfoAtten;
     }
 
     float lfoAtten{0.f};