Add permit2 for init pool #553
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattPereira
commented
Jan 12, 2025
MattPereira
commented
Jan 12, 2025
johngrantuk
reviewed
Jan 13, 2025
MattPereira
commented
Jan 13, 2025
Comment on lines
+332
to
+335
| const _owner = typeof owner === 'string' ? owner : owner.address; | ||
| let _nonce: number; | ||
| if (nonce === undefined) { | ||
| _nonce = await getNonce(client, token, owner, spender); | ||
| _nonce = await getNonce(client, token, _owner, spender); |
There was a problem hiding this comment.
@brunoguerios lmk if you agree with this approach and if we should allow Account for all the other sign helper methods as part of this PR or open a new issue
There was a problem hiding this comment.
Sure! It does seem a more robust approach. If it's just a matter of adding that single line for owner type check on each method, I'd go ahead and make the change 👍
|
No idea why unrelated swap tests are failing 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #476
Summary
getDetailsofPermit2Helperto allow for typeAccountso thatclient.signTypedDatacan be run with a script