Add support for partial unique indexes #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thgreasi
added a commit
to balena-io/pinejs
that referenced
this pull request
Nov 26, 2023
…ption Depends-on: balena-io-modules/abstract-sql-compiler#237 Change-type: minor
thgreasi
added a commit
to balena-io/pinejs
that referenced
this pull request
Dec 5, 2023
…ption Depends-on: balena-io-modules/abstract-sql-compiler#237 Change-type: minor
thgreasi
added a commit
to balena-io/pinejs
that referenced
this pull request
Jan 5, 2024
…ption Depends-on: balena-io-modules/abstract-sql-compiler#237 Change-type: minor
thgreasi
force-pushed
the
partial-unique-index
branch
from
12e3a0c to
555a2f6
Compare
thgreasi
added a commit
to balena-io/pinejs
that referenced
this pull request
Feb 6, 2024
…ption Depends-on: balena-io-modules/abstract-sql-compiler#237 Change-type: minor
thgreasi
added a commit
to balena-io/pinejs
that referenced
this pull request
Mar 19, 2024
…ption Depends-on: balena-io-modules/abstract-sql-compiler#237 Change-type: minor
thgreasi
commented
Mar 19, 2024
| name?: string; | ||
| description?: string; | ||
| nulls?: string; | ||
| predicate?: BooleanTypeNodes; |
There was a problem hiding this comment.
I got the name from the PG CREATE INDEX synopsis.
See: https://www.postgresql.org/docs/16/sql-createindex.html
thgreasi
added a commit
to balena-io/pinejs
that referenced
this pull request
Mar 19, 2024
…ption Depends-on: balena-io-modules/abstract-sql-compiler#237 Change-type: minor
Page-
reviewed
Mar 21, 2024
Comment on lines
+39
to
+43
| const sha = sbvrTypes.SHA.validateSync( | ||
| `${tableName}$${JSON.stringify(ruleBody)}`, | ||
| ).replace(/^\$sha256\$/, ''); | ||
| // Trim the trigger to a max of 63 characters, reserving at least 32 characters for the hash | ||
| return `${tableName.slice(0, 30)}$${sha}`.slice(0, 63); |
There was a problem hiding this comment.
I think it'd make sense for this to take inspiration from the roughly equivalent code in https://github.com/balena-io-modules/odata-to-abstract-sql/blob/v6.2.4/src/odata-to-abstract-sql.ts#L393-L396 - the things of note to me are:
- using base36 allows it to still be a string but also fit as much of the hash in as possible in the same number of characters (vs hex/base 16)
- adjusting the truncation dynamically based upon the actual strings
- using a named constant for
MAX_ALIAS_LENGTHrather than a magic number for which the reasoning is not as clear
thgreasi
added a commit
to balena-io/pinejs
that referenced
this pull request
Mar 21, 2024
…ption Depends-on: balena-io-modules/abstract-sql-compiler#237 Change-type: minor
thgreasi
force-pushed
the
partial-unique-index
branch
from
555a2f6 to
2998222
Compare
|
It seems that the latest TS fails to compile on master |
thgreasi
commented
Mar 21, 2024
src/AbstractSQLCompiler.ts
Outdated
Comment on lines
584
to
587
| // Without the `: SbvrType['validate']` widening TS complains that | ||
| // "none of those signatures are compatible with each other". | ||
| const validateFn: SbvrType['validate'] = | ||
| validateTypes[dataType as keyof typeof sbvrTypes]; |
There was a problem hiding this comment.
That's on master atm, and will be dropped from this PR once I rebase.
thgreasi
commented
Mar 21, 2024
package.json
Outdated
| @@ -36,7 +36,7 @@ | |||
| "lint-staged": "^13.2.1", | |||
| "mocha": "^10.2.0", | |||
| "ts-node": "^10.9.1", | |||
| "typescript": "^5.0.4" | |||
| "typescript": "^5.4.3" | |||
There was a problem hiding this comment.
Will be dropped once I rebase on top of master
Page-
approved these changes
Mar 22, 2024
Change-type: minor
Change-type: minor
Change-type: minor
thgreasi
force-pushed
the
partial-unique-index
branch
from
694b370 to
6d00b7d
Compare
thgreasi
added a commit
to balena-io/pinejs
that referenced
this pull request
Mar 26, 2024
…ption Update @balena/abstract-sql-compiler from 9.0.4 to 9.1.0 Depends-on: balena-io-modules/abstract-sql-compiler#237 Change-type: minor
thgreasi
added a commit
to balena-io/pinejs
that referenced
this pull request
Apr 2, 2024
…ption Update @balena/abstract-sql-compiler from 9.0.4 to 9.1.0 Depends-on: balena-io-modules/abstract-sql-compiler#237 Change-type: minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: minor
See: https://balena.zulipchat.com/#narrow/stream/346007-balena-io.2FbalenaCloud/topic/Pine.20Partial.20UNIQUE.20Index.20based.20rules