Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: run against compiled source rather than transpiling on the fly #851

Merged
merged 3 commits into from
Jan 4, 2025

Conversation

Page-
Copy link
Collaborator

@Page- Page- commented Jan 3, 2025

Change-type: patch

@Page- Page- requested a review from a team January 3, 2025 19:09
@Page- Page- marked this pull request as ready for review January 3, 2025 19:48
@@ -69,6 +68,7 @@
},
"devDependencies": {
"@balena/lint": "^8.2.8",
"@balena/pinejs": "file:./",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I've used file:<path> locally for testing but not for anything like this.

@joshbwlng
Copy link
Contributor

@Page- I noticed this diff after running npm run test:generated-types:

diff --git a/src/tasks/tasks.ts b/src/tasks/tasks.ts
index d499ff4b..9930e261 100644
--- a/src/tasks/tasks.ts
+++ b/src/tasks/tasks.ts
@@ -41,4 +41,6 @@ export interface Task {
 
 export default interface $Model {
 	task: Task;
-}
+
+
+}
\ No newline at end of file

@joshbwlng
Copy link
Contributor

@Page- I noticed this diff after running npm run test:generated-types:

diff --git a/src/tasks/tasks.ts b/src/tasks/tasks.ts
index d499ff4b..9930e261 100644
--- a/src/tasks/tasks.ts
+++ b/src/tasks/tasks.ts
@@ -41,4 +41,6 @@ export interface Task {
 
 export default interface $Model {
 	task: Task;
-}
+
+
+}
\ No newline at end of file

Ah, but I see this happens on master as well. Unrelated to this PR, but still something that should probably be fixed.

@joshbwlng joshbwlng merged commit 8a989e8 into master Jan 4, 2025
53 checks passed
@joshbwlng joshbwlng deleted the tests branch January 4, 2025 23:35
@Page-
Copy link
Collaborator Author

Page- commented Jan 6, 2025

@joshbwlng I would guess that's because of the difference between directly generated vs after linting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants