Fix issues with paths when using windows #33
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know we're moving away from this JS implementation soon, but it'd be very useful to get this in in the short-term anyway as a quick fix to unblock balena-io-modules/balena-device-init#25, where this currently breaks OS configuration in Windows.
Right now, reconfix breaks on windows because it tries to pass paths like
\\system-connections\\resin-wifi
toresin-image-fs
, which is having none of it, and claims that file doesn't exist.That is the right OS-local separator, but it completely doesn't work for resin-image-fs (as far as I can tell, that expects
/
all the time). This PR changes this to always generate paths like/system-connections/resin-wifi
instead, which always works, regardless of the local platform.