Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix mapping key issue in AnimatePresence component #135

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

ballyalley-o
Copy link
Owner

This pull request fixes the mapping key issue in the AnimatePresence component. The issue was causing a warning related to non-unique keys within components. To resolve this, the children of the AnimatePresence component are now mapped with a unique key using the index value. This ensures that each child element has a unique key prop assigned to it.

Fixes #128

@ballyalley-o ballyalley-o linked an issue Apr 15, 2024 that may be closed by this pull request
@ballyalley-o ballyalley-o requested a review from in-a-iii April 15, 2024 10:13
Copy link
Collaborator

@in-a-iii in-a-iii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please destructure Children from React instead.

src/hook/use-snack/use-snack.tsx Outdated Show resolved Hide resolved
@ballyalley-o ballyalley-o requested a review from in-a-iii April 15, 2024 10:21
Copy link
Collaborator

@in-a-iii in-a-iii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great.

@ballyalley-o ballyalley-o self-assigned this Apr 15, 2024
@ballyalley-o ballyalley-o merged commit 1592634 into development Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] Mapping key has multiple children
2 participants