Fix logo vectorization and update course view #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and adjust layout
… slice/bootcamp/index.ts
…place useEffect with useState for pagination and handle page change
This was
linked to
issues
Apr 23, 2024
in-a-iii
requested changes
Apr 23, 2024
in-a-iii
approved these changes
Apr 23, 2024
| @@ -20,8 +22,7 @@ const _svg = (svg: string) => { | |||
|
|
|||
| const ASSET = { | |||
| // bg | |||
| _BG_TEMP: 'https://images.pexels.com/photos/9672971/pexels-photo-9672971.jpeg?auto=compress&cs=tinysrgb&w=1260&h=750&dpr=2', | |||
| default_badge: 'https://thecodecoachprojct.com/upload/badge/no-badge.png', | |||
There was a problem hiding this comment.
Good to see you removed the unused bg temp
| @@ -4,6 +4,7 @@ const GLOBAL = { | |||
| APP_SERVER: import.meta.env.VITE_APP_SERVER, | |||
| APP_ORIGIN: import.meta.env.VITE_APP_ORIGIN, | |||
| APP_ENV: import.meta.env.VITE_APP_ENV, | |||
| DEFAULT_BADGE: import.meta.env.VITE_DEFAULT_BADGE, | |||
There was a problem hiding this comment.
Great, good to go for me,
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the logo to a vector format, making it the official logo for the project. The logo file has been replaced with a vector version, and the necessary changes have been made in the code to use the new logo. This improves the scalability and quality of the logo.