feat: allow aux funds for name registration #1065
Closed
+33
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🟡 Heimdall Review Status
|
|
@gareys-cb is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
JFrankfurt
reviewed
Oct 16, 2024
ghost
commented
Oct 17, 2024
Comment on lines
15
to
19
| // To add a new capability, add it to this list | ||
| const capabilitiesList = ['atomicBatch', 'paymasterService', 'auxiliaryFunds'] as const; | ||
|
|
||
| type ListedCapabilities = (typeof capabilitiesList)[number]; | ||
|
|
There was a problem hiding this comment.
The main goal of the refactor is to make this hook more easily updatable. Simply adding the capability name to this string[] is all you need to do to expose the capability through the hook.
ghost
requested review from
JFrankfurt
reviewed
Oct 17, 2024
JFrankfurt
approved these changes
Oct 17, 2024
|
Review Error for JFrankfurt @ 2024-10-17 19:53:55 UTC |
JFrankfurt
approved these changes
Oct 17, 2024
* add theme gif * add styled swap component image * add swap component before custom theme * add tutorial for custom themes in OCK
* discount code temp * comments * BE: Proof of concept * mark/increment code as consumed * bad code * bad code * dry it up * remove test code * cleanup and fix * suspense * undo change * refactor: use internal transaction/capacities hooks for registration flow * refetch basename * fix: wrong name being used when reverseRecord is false * prefetch * ssr code instead of search params * add banner & code
* use correct chain * use dynamic chain
kirkas
approved these changes
Oct 21, 2024
kirkas
approved these changes
Oct 21, 2024
zencephalon
force-pushed
the
master
branch
2 times, most recently
from
e8770ac to
c05a8df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This PR enables wallets using EIP-5792 with the
auxiliaryFundscapability to register Base names even when the wallet is unfunded.Currently, the "Register name" button is disabled.
With this change, wallets with the
auxiliaryFundscapability won't be restricted from buying when they have an insufficient wallet balance.video.mp4
Notes to reviewers
Try it out locally or watch the videos. I've run the tests listed below locally.
How has it been tested?
Test with a wallet without capabilities to see that the button is disabled when wallet is unfunded.
Test with CB Smart Wallet which has capabilities to see that the button is enabled when wallet is unfunded.
Test with any funded wallet to see that it works when wallet is funded.