Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Cloudinary integration #1071

Merged
merged 13 commits into from
Oct 15, 2024
Merged

Feat: Cloudinary integration #1071

merged 13 commits into from
Oct 15, 2024

Conversation

kirkas
Copy link
Collaborator

@kirkas kirkas commented Oct 14, 2024

Security

This should address the following security risks:

Integration

All images that are not hosted by us will automatically be proxied via ImageCloudinary.

Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 2:37pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 2:37pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 14, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@cb-heimdall
Copy link
Collaborator

Review Error for JFrankfurt @ 2024-10-15 15:54:30 UTC
User failed mfa authentication, see go/mfa-help

@kirkas kirkas merged commit 9a52003 into master Oct 15, 2024
8 checks passed
@kirkas kirkas deleted the feat/cloudinary-integration branch October 15, 2024 16:43
@JFrankfurt
Copy link
Contributor

🔥

kirkas added a commit that referenced this pull request Oct 21, 2024
* cloudinary integration wip

* cloudinary integration wip

* fetch & proxy

* fix lock

* remove lib due to wasm nonsense

* clean up

* Update apps/web/src/components/ImageCloudinary/index.tsx

Co-authored-by: Jordan Frankfurt <[email protected]>

* Update apps/web/src/components/ImageCloudinary/index.tsx

Co-authored-by: Jordan Frankfurt <[email protected]>

* add logger to the routes

* env example

* fix loading

---------

Co-authored-by: Jordan Frankfurt <[email protected]>
kirkas added a commit that referenced this pull request Oct 21, 2024
* cloudinary integration wip

* cloudinary integration wip

* fetch & proxy

* fix lock

* remove lib due to wasm nonsense

* clean up

* Update apps/web/src/components/ImageCloudinary/index.tsx

Co-authored-by: Jordan Frankfurt <[email protected]>

* Update apps/web/src/components/ImageCloudinary/index.tsx

Co-authored-by: Jordan Frankfurt <[email protected]>

* add logger to the routes

* env example

* fix loading

---------

Co-authored-by: Jordan Frankfurt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants