-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Cloudinary integration #1071
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Heimdall Review Status
|
kirkas
requested review from
JFrankfurt and
zencephalon
and removed request for
JFrankfurt
October 14, 2024 19:47
JFrankfurt
reviewed
Oct 14, 2024
apps/web/src/components/Basenames/UsernameProfileSectionFrames/FrameTheme.tsx
Outdated
Show resolved
Hide resolved
JFrankfurt
reviewed
Oct 14, 2024
JFrankfurt
reviewed
Oct 14, 2024
JFrankfurt
reviewed
Oct 14, 2024
JFrankfurt
reviewed
Oct 14, 2024
Co-authored-by: Jordan Frankfurt <[email protected]>
Co-authored-by: Jordan Frankfurt <[email protected]>
JFrankfurt
approved these changes
Oct 15, 2024
Review Error for JFrankfurt @ 2024-10-15 15:54:30 UTC |
JFrankfurt
approved these changes
Oct 15, 2024
🔥 |
kirkas
added a commit
that referenced
this pull request
Oct 21, 2024
* cloudinary integration wip * cloudinary integration wip * fetch & proxy * fix lock * remove lib due to wasm nonsense * clean up * Update apps/web/src/components/ImageCloudinary/index.tsx Co-authored-by: Jordan Frankfurt <[email protected]> * Update apps/web/src/components/ImageCloudinary/index.tsx Co-authored-by: Jordan Frankfurt <[email protected]> * add logger to the routes * env example * fix loading --------- Co-authored-by: Jordan Frankfurt <[email protected]>
kirkas
added a commit
that referenced
this pull request
Oct 21, 2024
* cloudinary integration wip * cloudinary integration wip * fetch & proxy * fix lock * remove lib due to wasm nonsense * clean up * Update apps/web/src/components/ImageCloudinary/index.tsx Co-authored-by: Jordan Frankfurt <[email protected]> * Update apps/web/src/components/ImageCloudinary/index.tsx Co-authored-by: Jordan Frankfurt <[email protected]> * add logger to the routes * env example * fix loading --------- Co-authored-by: Jordan Frankfurt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Security
This should address the following security risks:
Integration
All images that are not hosted by us will automatically be proxied via
ImageCloudinary
.