fix: better error messages for frames #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Heimdall Review Status
|
JFrankfurt
force-pushed
the
feature/bapp-640-improvement-better-frame-error-states
branch
from
88d08e6 to
c8da549
Compare
kirkas
approved these changes
Oct 17, 2024
| @@ -28,6 +59,51 @@ export default function Frame({ url, className }: FrameProps) { | |||
| }); | |||
| }; | |||
|
|
|||
| const useSharedCallback = <T extends SignatureData | TransactionData>( | |||
There was a problem hiding this comment.
This function is v hard to parse/read, maybe add comment or split?
JFrankfurt
deleted the
feature/bapp-640-improvement-better-frame-error-states
branch
kirkas
pushed a commit
that referenced
this pull request
Oct 21, 2024
kirkas
pushed a commit
that referenced
this pull request
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has each frame track its own errors, whereas before all errors were aggregated at the context level (dumb).
Errors quickly fade in, and fade out when clicked.