Feat: Registration Discount codes #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Heimdall Review Status
|
ricardoMogg
previously approved these changes
Oct 15, 2024
cb-heimdall
dismissed
ricardoMogg’s stale review
Approved review 2370486781 from ricardoMogg is now dismissed due to new commit. Re-request for approval.
JFrankfurt
reviewed
Oct 16, 2024
JFrankfurt
reviewed
Oct 16, 2024
|
lgtm but we do need that mainnet address uncommented before merge right? |
zencephalon
previously approved these changes
Oct 17, 2024
cb-heimdall
dismissed
zencephalon’s stale review
Approved review 2375576845 from zencephalon is now dismissed due to new commit. Re-request for approval.
|
@JFrankfurt yes waiting for contract on mainnet before mergin this. I'll also do a sepolia/codeflow test deploy first |
JFrankfurt
approved these changes
Oct 18, 2024
|
Review Error for JFrankfurt @ 2024-10-18 20:26:44 UTC |
JFrankfurt
approved these changes
Oct 18, 2024
kirkas
added a commit
that referenced
this pull request
Oct 21, 2024
* discount code temp * comments * BE: Proof of concept * mark/increment code as consumed * bad code * bad code * dry it up * remove test code * cleanup and fix * suspense * undo change * refactor: use internal transaction/capacities hooks for registration flow * refetch basename * fix: wrong name being used when reverseRecord is false * prefetch * ssr code instead of search params * add banner & code
kirkas
added a commit
that referenced
this pull request
Oct 21, 2024
* discount code temp * comments * BE: Proof of concept * mark/increment code as consumed * bad code * bad code * dry it up * remove test code * cleanup and fix * suspense * undo change * refactor: use internal transaction/capacities hooks for registration flow * refetch basename * fix: wrong name being used when reverseRecord is false * prefetch * ssr code instead of search params * add banner & code
kirkas
added a commit
that referenced
this pull request
Oct 21, 2024
* discount code temp * comments * BE: Proof of concept * mark/increment code as consumed * bad code * bad code * dry it up * remove test code * cleanup and fix * suspense * undo change * refactor: use internal transaction/capacities hooks for registration flow * refetch basename * fix: wrong name being used when reverseRecord is false * prefetch * ssr code instead of search params * add banner & code
kirkas
added a commit
that referenced
this pull request
Oct 21, 2024
* [Tutorial] Apply custom theme to Swap component (#1098) * add theme gif * add styled swap component image * add swap component before custom theme * add tutorial for custom themes in OCK * Feat: Registration Discount codes (#1084) * discount code temp * comments * BE: Proof of concept * mark/increment code as consumed * bad code * bad code * dry it up * remove test code * cleanup and fix * suspense * undo change * refactor: use internal transaction/capacities hooks for registration flow * refetch basename * fix: wrong name being used when reverseRecord is false * prefetch * ssr code instead of search params * add banner & code * Fix: Use correct chain for discoutn code (#1107) * use correct chain * use dynamic chain * Revert "[Tutorial] Apply custom theme to Swap component (#1098)" (#1111) This reverts commit c38fcab. --------- Co-authored-by: Pat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing Discount Codes for Basenames.
This PR is addresses two body of works.
1. Promo Code
Get the code from the url
?code=...See
searchParams?.codeinapps/web/app/(basenames)/names/page.tsx.Pass the code to the attestations hooks
Introducing
useDiscountCodeAttestations, fetch data from a new endpoint:/api/proofs/discountCode. This endpoints compare, validate & sign the code.From here the existing attestations logic handles the discount automatically.
2. RegisterName refactor
We've had issues with the register flow for Smart Wallet, which led to a small refactor.
This flow is the first one we built, and we've since introduced helpful hooks like
useWriteContractsWithLogsanduseWriteContractWithReceiptfor better, safer tracking of web3 transactions.Changes to
RegistrationContextTo avoid rendering race condition and other state / logic mishaps, we moved all the shared logic and state to the Context. This includes
useRegisterNameCallback,setYears,price, etc..Changes to
RegistrationFormSince the context holds the logic and state, this greatly simplify this components.
Changes to
useRegisterNameCallbackThis hook holds all the logic regarding initiating & tracking transactions, including error and analytics. This simplifies and consolidate Basename registration contract logic into one place.
Changes to
RegistrationProfileFormFix which name you are editing.