Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Valora #1206

Closed
wants to merge 1 commit into from
Closed

Add Valora #1206

wants to merge 1 commit into from

Conversation

silasbw
Copy link

@silasbw silasbw commented Nov 5, 2024

No description provided.

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 5:18pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 5, 2024

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

Copy link

vercel bot commented Nov 5, 2024

@silasbw is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@wbnns
Copy link
Member

wbnns commented Nov 8, 2024

@silasbw

Hi there! Thanks for this PR! Confirming this is in our backlog, pending to be reviewed.

@wbnns wbnns self-assigned this Nov 8, 2024
@wbnns wbnns removed their assignment Dec 19, 2024
@wbnns
Copy link
Member

wbnns commented Dec 19, 2024

@silasbw

Hi there! Apologies, we recently updated the way we categorize and subcategorize apps; could you please reopen a new PR defining the category and subcategory to wallet and one of the sub categories?

We'll do our best to review as soon as possible once you do! 🙏

@wbnns wbnns added change(s) requested One or more changes have been requested and removed community contribution labels Dec 19, 2024
@wbnns
Copy link
Member

wbnns commented Dec 28, 2024

@silasbw Please open a new PR once the above changes have been made.

@wbnns wbnns closed this Dec 28, 2024
@silasbw
Copy link
Author

silasbw commented Dec 30, 2024

OK, thanks!

@silasbw
Copy link
Author

silasbw commented Dec 30, 2024

Here's the replacement one @wbnns: #1515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base ecosystem review This is ecosystem related change(s) requested One or more changes have been requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants