Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Add IPFS / Pinata avatar upload #971

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Conversation

kirkas
Copy link
Collaborator

@kirkas kirkas commented Aug 29, 2024

IPFS Upload and resolution via Pinata

@kirkas kirkas requested a review from zencephalon August 29, 2024 18:36
Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 7:04pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 7:04pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Aug 29, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@kirkas kirkas requested a review from JFrankfurt August 29, 2024 18:36
zencephalon
zencephalon previously approved these changes Aug 29, 2024
Copy link
Collaborator

@zencephalon zencephalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just confirming for myself that we already have cloudflare in img-src csp 👍

@kirkas
Copy link
Collaborator Author

kirkas commented Aug 29, 2024

@zencephalon yeah we got https://cloudflare-ipfs.com

@cb-heimdall cb-heimdall dismissed zencephalon’s stale review August 29, 2024 18:50

Approved review 2269807018 from zencephalon is now dismissed due to new commit. Re-request for approval.

@kirkas kirkas requested a review from zencephalon August 29, 2024 18:51
@kirkas kirkas merged commit 3fc8f8f into master Aug 29, 2024
7 checks passed
@kirkas kirkas deleted the feat/ipfs-pinata-upload branch August 29, 2024 19:05
kirkas added a commit that referenced this pull request Oct 21, 2024
* Add IPFS / Pinata avatar upload

* fix build: deprecated config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants