-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exec_group_compatible_with
attribute
#24964
Draft
fmeum
wants to merge
15
commits into
bazelbuild:master
Choose a base branch
from
fmeum:23802-add-exec-group-compatible-with
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add exec_group_compatible_with
attribute
#24964
fmeum
wants to merge
15
commits into
bazelbuild:master
from
fmeum:23802-add-exec-group-compatible-with
+974
−165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
23802-add-exec-group-compatible-with
branch
2 times, most recently
from
January 19, 2025 10:32
3df50ad
to
b54072a
Compare
This makes `exec_properties` such as `no-remote-exec` effective for the main test spawn, where it previously only affected post-processing spawns such as test XML generation.
on this reproducer: #23202 (comment) w/ this change (and the exec_properties one) I get this crash:
i looked into this a bit last week and I believe it's because this function
|
fmeum
force-pushed
the
23802-add-exec-group-compatible-with
branch
from
January 22, 2025 12:30
8528676
to
c943de3
Compare
verified on the latest commits here it works with this repro case now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements the Per-target execution platform constraints for exec groups proposal by adding the
exec_group_compatible_with
attribute. It differs from the proposal in its accepted from in two ways:test
exec group always inherits toolchain requirements and constraints from the default exec group. This behavior makes it impossible to apply additional constraints to the default exec group viaexec_compatible_with
without also applying them to thetest
exec group. This preexisting behavior has mostly undesirable consequences: In a multi- or cross-platform build, where exec constraints matter, tests actions and build actions areFixes #23202
Fixes #23802
RELNOTES: The new
exec_group_compatible_with
attribute on all rules accepts a dictionary mapping exec group names to lists of additional constraints to request from the exec group's execution platform.RELNOTES[INC]: Constraints and toolchain requirements added to the default exec group, for example via the
toolchains
parameter of therule
function or theexec_compatible_with
attribute on all rules, no longer apply to thetest
exec group, which contains the test action on test rules. Instead, useexec_group_compatible_with
to apply constraints and/or define an explicittest
exec group with toolchain requirements on test rules that require it.