Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.1.0] Add conlyopts / cxxopts to objc_library #25022

Open
wants to merge 2 commits into
base: release-8.1.0
Choose a base branch
from
Open

[8.1.0] Add conlyopts / cxxopts to objc_library #25022

wants to merge 2 commits into from

Conversation

keith
Copy link
Member

@keith keith commented Jan 22, 2025

Closes #24834

pzembrod and others added 2 commits January 22, 2025 11:22
@pzembrod @keith
Automated rollback of commit 9ee7b1b.
17fb166 
*** Reason for rollback ***

Roll forward with fix

*** Original change description ***

Automated rollback of commit 6a62098.

*** Reason for rollback ***

Internal breakages

*** Original change description ***

Starlarkify objc/CompilationAttributes.java

Closes bazelbuild#24009.

PiperOrigin-RevId: 695266024
Change-Id: I5c8615b5869e27a81ba10462e47af46336d3178c
(cherry picked from commit c3346a5)
@keith
Add conlyopts / cxxopts to objc_library
b6a911a 
This mirrors the behavior from cc_library

Closes bazelbuild#24497.

PiperOrigin-RevId: 711864090
Change-Id: I284c466c67d476836f2c0b561d06e919bd7860e3
(cherry picked from commit d38b16e)
@keith keith requested a review from a team as a code owner January 22, 2025 19:24
@github-actions github-actions bot added team-Rules-CPP Issues for C++ rules team-Rules-ObjC Issues for Objective-C maintainers awaiting-review PR is awaiting review from an assigned reviewer labels Jan 22, 2025
@keith keith mentioned this pull request Jan 22, 2025
Open
@keith keith requested a review from iancha1992 January 22, 2025 19:24
@iancha1992 iancha1992 requested review from lberki and pzembrod and removed request for iancha1992 January 22, 2025 21:26
@iancha1992 iancha1992 enabled auto-merge January 22, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lberki lberki Awaiting requested review from lberki

@pzembrod pzembrod Awaiting requested review from pzembrod

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-Rules-CPP Issues for C++ rules team-Rules-ObjC Issues for Objective-C maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keith @pzembrod